coderfender commented on code in PR #3383:
URL: https://github.com/apache/datafusion-comet/pull/3383#discussion_r2767651072
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -989,8 +989,7 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateDates(), DataTypes.StringType)
}
- ignore("cast DateType to TimestampType") {
- // Arrow error: Cast error: Casting from Date32 to Timestamp(Microsecond,
Some("UTC")) not supported
+ test("cast DateType to TimestampType") {
castTest(generateDates(), DataTypes.TimestampType)
Review Comment:
Thank you @andygrove . I added set of dates covering almost all DST start
and end dates for various timezones across US, EU, Asia and Australia. I also
added some sample dates for future along with regular dates starting from epoch
to make sure we have wide coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
