andygrove commented on code in PR #3351:
URL: https://github.com/apache/datafusion-comet/pull/3351#discussion_r2765234357


##########
dev/diffs/3.4.3.diff:
##########
@@ -1872,6 +1883,62 @@ index 593bd7bb4ba..32af28b0238 100644
          }
          assert(shuffles2.size == 4)
          val smj2 = findTopLevelSortMergeJoin(adaptive2)
+diff --git 
a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CharVarcharDDLTestBase.scala
 
b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CharVarcharDDLTestBase.scala
+index f77b6336b81..b703603d26b 100644
+--- 
a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CharVarcharDDLTestBase.scala
++++ 
b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CharVarcharDDLTestBase.scala
+@@ -18,7 +18,7 @@
+ package org.apache.spark.sql.execution.command
+ 
+ import org.apache.spark.SparkConf
+-import org.apache.spark.sql.{AnalysisException, QueryTest, Row}
++import org.apache.spark.sql.{AnalysisException, IgnoreComet, QueryTest, Row}
+ import org.apache.spark.sql.catalyst.util.CharVarcharUtils
+ import org.apache.spark.sql.connector.catalog.InMemoryPartitionTableCatalog
+ import org.apache.spark.sql.internal.SQLConf
+@@ -112,7 +112,8 @@ trait CharVarcharDDLTestBase extends QueryTest with 
SQLTestUtils {
+     }
+   }
+ 
+-  test("SPARK-33901: ctas should should not change table's schema") {
++  test("SPARK-33901: ctas should should not change table's schema",
++    IgnoreComet("comet native writer does not support empty dir / table 
creation yet")) {

Review Comment:
   Could you link to the specific GitHub issues in the `IgnoreComet` 
annotations?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to