pepijnve commented on PR #19994: URL: https://github.com/apache/datafusion/pull/19994#issuecomment-3851340222
> It seems that effect of Divide by zero protection is not significant.🤣 Those last results are in line with what I was seeing locally. You get a speedup when there is a small percentage of zeroes, but a slow down when there are many. Not sure what the wisest choice is for this one. Personally I think I’m inclined to keep focussing on squeezing more out of the general pattern code paths than adding very specialized ones. Perhaps with some more profiling and optimisation work we can shave some more off the general 10% variant for instance? I haven’t looked at that closely yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
