LLDay commented on code in PR #20009:
URL: https://github.com/apache/datafusion/pull/20009#discussion_r2769571403
##########
datafusion/core/tests/physical_optimizer/pushdown_utils.rs:
##########
@@ -155,6 +155,16 @@ impl FileSource for TestSource {
})
}
+ fn with_filter_and_projection(
Review Comment:
Thank you for the review! I have updated the PR description. This method
allows to override the physical expressions within a file source. For example,
we will be able to replace placeholder physical expressions. You can see it
[here](https://github.com/LLDay/datafusion/blob/eb09e719ef4e825ea154021f874c581405d4240d/datafusion/sqllogictest/test_files/placeholders.slt#L121-L142)
(I removed `ResolvePlaceholdersExec` from the PR, but it worked by finding the
placeholders and then replacing them with literals).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
