LLDay commented on code in PR #20009:
URL: https://github.com/apache/datafusion/pull/20009#discussion_r2769574584
##########
datafusion/datasource/src/source.rs:
##########
@@ -215,6 +215,39 @@ pub trait DataSource: Send + Sync + Debug {
fn with_preserve_order(&self, _preserve_order: bool) -> Option<Arc<dyn
DataSource>> {
None
}
+
+ /// Returns an iterator over a subset of [`PhysicalExpr`]s that are used
by this [`DataSource`].
+ fn physical_expressions<'a>(
+ &'a self,
+ ) -> Option<Box<dyn Iterator<Item = Arc<dyn PhysicalExpr>> + 'a>> {
+ None
Review Comment:
I wanted these changes to be non-breaking. At least, until we implemented a
reliable mechanism using these methods (such as `ResolvePlaceholdersExec` or
something else).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
