YutaLin commented on PR #3405: URL: https://github.com/apache/datafusion-comet/pull/3405#issuecomment-3857881416
Hi @mbutrovich, thanks for the review! I investigated adding a SQL test, but found out Years is a PartitionTransformExpression that extends Unevaluable in Spark, which means spark itself cannot execute Years at run time, it would throws `[INTERNAL_ERROR] cannot generate code for expression`, I cannot write SELECT years(col) or WHERE years(col) = 2024, it's only used as partition metadata, could you guide me on the best way to add a solid test to verify the partitioning? I've added tests to verify serialization and support level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
