adriangb commented on PR #20159: URL: https://github.com/apache/datafusion/pull/20159#issuecomment-3859913330
> Here are the results from the clickbench benchmark. With 1GB memory limit, however we reach the resource limits but the bug doesn't materialize with the change: > > [fix_spill_read_underrun.log](https://github.com/user-attachments/files/25119991/fix_spill_read_underrun.log) [main.log](https://github.com/user-attachments/files/25119993/main.log) [clickbench_partitioned.json - fix](https://github.com/user-attachments/files/25119997/clickbench_partitioned.json) [clickbench_partitioned.json - main](https://github.com/user-attachments/files/25120001/clickbench_partitioned.json) Here's the comparison: ``` ┏━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ spill-main ┃ spill ┃ Change ┃ ┡━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 1.42 ms │ 1.29 ms │ +1.10x faster │ │ QQuery 1 │ 12.26 ms │ 10.22 ms │ +1.20x faster │ │ QQuery 2 │ 24.56 ms │ 21.90 ms │ +1.12x faster │ │ QQuery 3 │ 54.30 ms │ 52.67 ms │ no change │ │ QQuery 4 │ 589.73 ms │ 544.75 ms │ +1.08x faster │ │ QQuery 5 │ FAIL │ FAIL │ incomparable │ │ QQuery 6 │ 22.91 ms │ 8.33 ms │ +2.75x faster │ │ QQuery 7 │ 13.95 ms │ 38.71 ms │ 2.78x slower │ │ QQuery 8 │ 1100.09 ms │ 1089.94 ms │ no change │ │ QQuery 9 │ 476.05 ms │ 443.06 ms │ +1.07x faster │ │ QQuery 10 │ 124.00 ms │ 115.41 ms │ +1.07x faster │ │ QQuery 11 │ 134.52 ms │ 122.89 ms │ +1.09x faster │ │ QQuery 12 │ FAIL │ FAIL │ incomparable │ │ QQuery 13 │ FAIL │ FAIL │ incomparable │ │ QQuery 14 │ FAIL │ FAIL │ incomparable │ │ QQuery 15 │ 1013.17 ms │ 1038.87 ms │ no change │ │ QQuery 16 │ FAIL │ FAIL │ incomparable │ │ QQuery 17 │ FAIL │ FAIL │ incomparable │ │ QQuery 18 │ FAIL │ FAIL │ incomparable │ │ QQuery 19 │ 136.08 ms │ 88.19 ms │ +1.54x faster │ │ QQuery 20 │ 439.50 ms │ 1187.21 ms │ 2.70x slower │ │ QQuery 21 │ 608.01 ms │ 765.89 ms │ 1.26x slower │ │ QQuery 22 │ 1248.89 ms │ 1256.74 ms │ no change │ │ QQuery 23 │ 6601.82 ms │ 4627.75 ms │ +1.43x faster │ │ QQuery 24 │ 68.26 ms │ 78.68 ms │ 1.15x slower │ │ QQuery 25 │ 121.97 ms │ 100.81 ms │ +1.21x faster │ │ QQuery 26 │ 85.14 ms │ 77.47 ms │ +1.10x faster │ │ QQuery 27 │ 615.13 ms │ 524.61 ms │ +1.17x faster │ │ QQuery 28 │ FAIL │ FAIL │ incomparable │ │ QQuery 29 │ 223.85 ms │ 201.93 ms │ +1.11x faster │ │ QQuery 30 │ 539.42 ms │ 495.41 ms │ +1.09x faster │ │ QQuery 31 │ 1123.87 ms │ 1016.04 ms │ +1.11x faster │ │ QQuery 32 │ 5227.16 ms │ 5989.61 ms │ 1.15x slower │ │ QQuery 33 │ FAIL │ FAIL │ incomparable │ │ QQuery 34 │ FAIL │ FAIL │ incomparable │ │ QQuery 35 │ 999.16 ms │ 991.90 ms │ no change │ │ QQuery 36 │ FAIL │ 365.41 ms │ incomparable │ │ QQuery 37 │ 37.26 ms │ 38.01 ms │ no change │ │ QQuery 38 │ 58.04 ms │ 59.82 ms │ no change │ │ QQuery 39 │ 297.38 ms │ 562.74 ms │ 1.89x slower │ │ QQuery 40 │ 19.25 ms │ 20.12 ms │ no change │ │ QQuery 41 │ 18.30 ms │ 17.35 ms │ +1.05x faster │ │ QQuery 42 │ 16.78 ms │ 14.57 ms │ +1.15x faster │ └───────────┴────────────┴────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (spill-main) │ 22052.23ms │ │ Total Time (spill) │ 21602.90ms │ │ Average Time (spill-main) │ 689.13ms │ │ Average Time (spill) │ 675.09ms │ │ Queries Faster │ 18 │ │ Queries Slower │ 6 │ │ Queries with No Change │ 8 │ │ Queries with Failure │ 11 │ └───────────────────────────┴────────────┘ ```` This looks good to me, there's some slowdowns but overwhelmingly speedups and fails -> not fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
