andygrove commented on PR #2772: URL: https://github.com/apache/datafusion-comet/pull/2772#issuecomment-3874115823
> This looks great overall @Shekharrajak, but could you mark it as incompatible as described in [#2772 (comment)](https://github.com/apache/datafusion-comet/pull/2772#issuecomment-3529547218). I don't think it is realistic to be able to match Spark behavior fully, at least not as part of this PR. > > In future PRs, we can probably implement fallback rules for specific cases, such as Java-specific regex patterns. I was able to find cases where Comet crashes at runtime when using lookahead, lookbehind, and back references, for example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
