cj-zhukov commented on PR #20252: URL: https://github.com/apache/datafusion/pull/20252#issuecomment-3875937113
### High-level overview This PR follows up on review feedback and focuses on small structural and correctness improvements, without changing any user-facing behavior. Specifically, this PR: - Moves the `ABBREVIATIONS` constant from `render` to `model` to eliminate an unnecessary circular dependency between modules. - Improves `discover_example_groups` to better handle edge cases, such as empty example roots or directories named `main.rs`. The function now fails fast with a clear error when no valid example groups are found. - Adds additional unit tests for the discovery logic to cover these edge cases and make the behavior explicit and well-documented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
