cj-zhukov commented on code in PR #20252:
URL: https://github.com/apache/datafusion/pull/20252#discussion_r2791656800
##########
datafusion-examples/src/utils/example_metadata/discover.rs:
##########
@@ -35,10 +36,18 @@ pub fn discover_example_groups(root: &Path) ->
Result<Vec<PathBuf>> {
let entry = entry?;
let path = entry.path();
- if path.is_dir() && path.join("main.rs").exists() {
+ if path.is_dir() && path.join("main.rs").is_file() {
groups.push(path);
}
}
+
+ if groups.is_empty() {
+ return Err(DataFusionError::Execution(format!(
Review Comment:
Good point! I'm going to update to use exec_err! for consistency with the
rest of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
