alamb commented on code in PR #20247:
URL: https://github.com/apache/datafusion/pull/20247#discussion_r2789644432
##########
datafusion/physical-optimizer/src/enforce_sorting/sort_pushdown.rs:
##########
@@ -353,6 +354,8 @@ fn pushdown_requirement_to_children(
Ok(None)
}
}
+ } else if let Some(aggregate_exec) =
plan.as_any().downcast_ref::<AggregateExec>() {
+ handle_aggregate_pushdown(aggregate_exec, parent_required)
Review Comment:
This comment explains why this is needed:
https://github.com/apache/datafusion/pull/19287#discussion_r2789573897
Basically the generic version is not correct for `AggregateExec`, but this
was masked due to some limitations that were lifted in
https://github.com/apache/datafusion/pull/19287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
