notashes commented on PR #20168:
URL: https://github.com/apache/datafusion/pull/20168#issuecomment-3884651785
Hey @Jefffrey, this is ready for review! Would appreciate your feedback
whenever you get time! Thanks
benchmark results (locally tested)
<details>
```
group this-branch
main
----- ----------
---------
dictionary_utf8_int32: multiple, no nulls 1.00 13.9±0.20µs ?
?/sec 2.33 32.4±0.41µs ? ?/sec
dictionary_utf8_int32: multiple, nulls 1.00 21.2±0.69µs ?
?/sec 1.73 36.7±0.43µs ? ?/sec
dictionary_utf8_int32: single, no nulls 1.00 5.1±0.17µs ?
?/sec 2.24 11.5±0.28µs ? ?/sec
dictionary_utf8_int32: single, nulls 1.00 7.3±0.33µs ?
?/sec 1.72 12.6±0.12µs ? ?/sec
int64: multiple, no nulls 1.00 14.8±0.21µs ?
?/sec 1.02 15.0±0.19µs ? ?/sec
int64: multiple, nulls 1.00 25.6±0.30µs ?
?/sec 1.00 25.6±0.24µs ? ?/sec
int64: single, no nulls 1.01 4.6±0.17µs ?
?/sec 1.00 4.5±0.16µs ? ?/sec
int64: single, nulls 1.00 8.2±0.10µs ?
?/sec 1.01 8.3±0.13µs ? ?/sec
large_utf8: multiple, no nulls 1.00 63.2±1.04µs ?
?/sec 1.00 63.1±0.69µs ? ?/sec
large_utf8: multiple, nulls 1.01 71.0±1.16µs ?
?/sec 1.00 70.3±0.66µs ? ?/sec
large_utf8: single, no nulls 1.00 20.5±0.24µs ?
?/sec 1.01 20.8±0.18µs ? ?/sec
large_utf8: single, nulls 1.00 23.0±0.28µs ?
?/sec 1.00 22.9±0.71µs ? ?/sec
run_array_int32: multiple, no nulls 1.00 4.0±0.09µs ?
?/sec 1.34 5.3±0.05µs ? ?/sec
run_array_int32: multiple, nulls 1.00 4.9±0.08µs ?
?/sec 1.13 5.5±0.09µs ? ?/sec
run_array_int32: single, no nulls 1.00 2.0±0.26µs ?
?/sec 1.18 2.4±0.18µs ? ?/sec
run_array_int32: single, nulls 1.00 2.4±0.25µs ?
?/sec 1.01 2.4±0.19µs ? ?/sec
struct_array: multiple, no nulls 1.00 124.7±0.98µs ?
?/sec 1.09 136.3±1.16µs ? ?/sec
struct_array: multiple, nulls 1.00 146.9±1.44µs ?
?/sec 1.10 161.3±1.75µs ? ?/sec
struct_array: single, no nulls 1.00 42.3±0.60µs ?
?/sec 1.09 45.9±0.64µs ? ?/sec
struct_array: single, nulls 1.00 49.8±0.50µs ?
?/sec 1.09 54.4±0.60µs ? ?/sec
utf8: multiple, no nulls 1.00 61.6±0.60µs ?
?/sec 1.01 62.2±0.92µs ? ?/sec
utf8: multiple, nulls 1.02 71.1±1.55µs ?
?/sec 1.00 70.0±0.69µs ? ?/sec
utf8: single, no nulls 1.00 20.7±0.30µs ?
?/sec 1.00 20.7±0.21µs ? ?/sec
utf8: single, nulls 1.01 22.9±1.25µs ?
?/sec 1.00 22.6±0.26µs ? ?/sec
utf8_view (small): multiple, no nulls 1.00 19.5±0.24µs ?
?/sec 1.00 19.6±0.22µs ? ?/sec
utf8_view (small): multiple, nulls 1.00 29.2±0.18µs ?
?/sec 1.01 29.5±0.28µs ? ?/sec
utf8_view (small): single, no nulls 1.02 5.5±0.08µs ?
?/sec 1.00 5.3±0.08µs ? ?/sec
utf8_view (small): single, nulls 1.00 9.1±0.07µs ?
?/sec 1.01 9.2±0.08µs ? ?/sec
utf8_view: multiple, no nulls 1.00 54.9±0.73µs ?
?/sec 1.02 56.2±1.12µs ? ?/sec
utf8_view: multiple, nulls 1.02 63.0±0.77µs ?
?/sec 1.00 61.9±0.72µs ? ?/sec
utf8_view: single, no nulls 1.03 18.1±0.40µs ?
?/sec 1.00 17.7±0.28µs ? ?/sec
utf8_view: single, nulls 1.01 19.9±0.21µs ?
?/sec 1.00 19.6±0.37µs ? ?/sec
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
