mkleen commented on code in PR #20047:
URL: https://github.com/apache/datafusion/pull/20047#discussion_r2797453132


##########
datafusion/common/Cargo.toml:
##########
@@ -75,7 +75,7 @@ indexmap = { workspace = true }
 itertools = { workspace = true }
 libc = "0.2.180"
 log = { workspace = true }
-object_store = { workspace = true, optional = true }
+object_store = { workspace = true, optional = true, default-features = true }

Review Comment:
   This works on builds and test but fails on 
   ```cargo check datafusion-common features```
   
   Is there a better way to declare this dependency?  Would it maybe better to 
leave it out and just account the internal string of Path?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to