Acfboy opened a new pull request, #20306:
URL: https://github.com/apache/datafusion/pull/20306
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #20201 .
## Rationale for this change
Unlike `Projection`, expressions within a `Filter` node do not always have
their types resolved during the initial LogicalPlan generation. Validation is
often deferred until the type_coercion phase. While operators with specific
type requirements (e.g., IS TRUE) trigger coercion and catch malformed
expressions, type-neutral operators (e.g., IS NULL) bypass this check, allowing
invalid expressions to reach the optimizer and cause a panic.
For example, all statements below cause a panic:
```
SELECT * FROM (SELECT 1) WHERE (STARTS_WITH() IS NULL);
SELECT * FROM (SELECT 1) WHERE (STARTS_WITH() IS NOT NULL);
SELECT * FROM (SELECT 'a') WHERE (STARTS_WITH() SIMILAR TO 'abc%');
SELECT * FROM (SELECT 1) WHERE CAST(STARTS_WITH() AS STRING) = 'x';
SELECT * FROM (SELECT 1) WHERE TRY_CAST(STARTS_WITH() AS INT) IS NULL;
```
This pr aims to stop panic. It would be better if reject these invalid cases
at planning.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Add checks like this in `type_coercion.rs`:
```rust
Expr::IsNotNull(ref inner_expr) | Expr::IsNull(ref inner_expr) => {
let _check_type = inner_expr.get_type(self.schema)?;
Ok(Transformed::no(expr))
}
```
## Are these changes tested?
All original tests passed. Added some unit tests and sqllogictests.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
