Acfboy commented on code in PR #20306:
URL: https://github.com/apache/datafusion/pull/20306#discussion_r2802497284
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -2742,4 +2771,69 @@ mod test {
"
)
}
+
+ fn zero_arg_scalar_func() -> Expr {
+ let fun = ScalarUDF::new_from_impl(TestScalarUDF {
+ signature: Signature::uniform(1, vec![DataType::Float32],
Volatility::Stable),
+ });
+ Expr::ScalarFunction(ScalarFunction::new_udf(Arc::new(fun), vec![]))
+ }
+
+ #[test]
Review Comment:
I don't see it as overlapping. slt ensures the whole path works, and unit
tests are there to help us isolate the root cause when something goes wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
