dekuu5 commented on code in PR #20067: URL: https://github.com/apache/datafusion/pull/20067#discussion_r2798771911
########## datafusion/physical-plan/src/spill/spill_manager.rs: ########## Review Comment: > Now, `read_spill_as_stream()` is exactly the same as `read_spill_as_stream_unbuffered()` below. Maybe the buffering impl should have been preserved but the caller with the issue should have been changed to use `read_spill_as_stream_unbuffered()` ?! yes indeed but i wrote this before #20159 was merged i was thinking about doing an unbuffered stream but i thought no other functions use it so why make another one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
