coderfender commented on PR #3491: URL: https://github.com/apache/datafusion-comet/pull/3491#issuecomment-3892392044
@andygrove , thank you for the review. The `Utf8` addition to `can_cast_from_boolean` changes `cast_supported`'s return value (to true) for Boolean→String. However, cast_supported is not called anywhere on main except self-recursive for structs which could have been the reason this bug was not surfaced in the first place . This addition makes it consistent with `is_datafusion_spark_compatible` macro both of which already support Boolean -> String Flow on main branch : 1. `is_datafusion_spark_compatible` -> `matches!` macro (for simple types) 2. `can_cast_from_boolean` function is only called for struct / recursive casts (which missed cast support to `Utf8`) Feature 1. `can_cast_from_boolean` acts as a single source of truth (with identity cast support) for all casts from boolean type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
