alamb commented on code in PR #20274:
URL: https://github.com/apache/datafusion/pull/20274#discussion_r2801269202
##########
.github/workflows/rust.yml:
##########
@@ -45,7 +45,7 @@ jobs:
# Check crate compiles and base cargo check passes
linux-build-lib:
name: linux build test
- runs-on: ${{ github.repository_owner == 'apache' &&
format('runs-on={0},family=m7a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion',
github.run_id) || 'ubuntu-latest' }}
+ runs-on: ${{ github.repository_owner == 'apache' &&
format('runs-on={0},family=m8a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion',
github.run_id) || 'ubuntu-latest' }}
Review Comment:
One thing I was thinking is that someone in the future may run into this and
have a hard time understanding what all the runs-on is all about
I didn't see it documented anywhere --
https://github.com/search?q=repo%3Aapache%2Fdatafusion%20runs-on&type=code
Is there any chance that you could write up some documentation in a README
that explains why we are using `runs-on` and how to apply/unapply it?
For example, it might not be obvious without the context of this PR, to know
that
```yaml
runs-on: ${{ github.repository_owner == 'apache' &&
format('runs-on={0},family=m8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion',
github.run_id) || 'ubuntu-latest' }}
```
Was the same as
```yaml
runs-on: ubuntu-latest
```
Except that in the apache repo it triggers the use of special runners
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
