adriangb commented on PR #20117: URL: https://github.com/apache/datafusion/pull/20117#issuecomment-3893708080
Thank you @ethan-tyler and @alamb for the review. Andrew I am happy to help efforts to improve performance of logical optimizer. Like we've discussed on calls the solution is likely "big wins" like making the optimizer runs copy on write instead of always copy. Other solutions like micro-optimizing individual optimizer rules or trying to reduce optimizer rules are likely to have a negative tradeoff in terms of code complexity or functionality. I plan to merge this once CI passes since it's relatively self contained (should not disrupt other users and doesn't change any public APIs) and has been open for several days in nearly the same state. I'm happy to address any further feedback in follow up PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
