LiaCastaneda commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2806021143
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -46,6 +47,9 @@ impl FilterState {
}
}
+/// Per-partition filter expressions indexed by partition number.
+type PartitionedFilters = Vec<Option<Arc<dyn PhysicalExpr>>>;
Review Comment:
Just one more question -- how would evaluation be done for
PartitionedFilters?
My understanding is that each partition would need to first access its
corresponding `PhysicalExpr` and then call `evaluate()` right? However, the
`evaluate()` trait of `PhysicalExpr` has no partition number in the args, so`
evaluate() `can't directly integrate `PartitionedFilters`.
The current `evaluate() `function remains the same and evaluates inner.expr,
which, when we preserve file partitioning, holds nothing (just lit(true)
placeholder).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
