LiaCastaneda commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2807927012
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -46,6 +47,9 @@ impl FilterState {
}
}
+/// Per-partition filter expressions indexed by partition number.
+type PartitionedFilters = Vec<Option<Arc<dyn PhysicalExpr>>>;
Review Comment:
ah got it, I missed the fact that this was already integrated into the
parquet-source opener, and thought evaluation was different. It's clear now,
thanks for explaining!
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -46,6 +47,9 @@ impl FilterState {
}
}
+/// Per-partition filter expressions indexed by partition number.
+type PartitionedFilters = Vec<Option<Arc<dyn PhysicalExpr>>>;
Review Comment:
ah got it, I missed the fact that this was already integrated into the
parquet-source opener, and thought evaluation was different. It's clear now and
makes sense to me, thanks for explaining!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
