neilconway commented on code in PR #20317:
URL: https://github.com/apache/datafusion/pull/20317#discussion_r2806379196
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -207,7 +207,11 @@ impl ScalarUDFImpl for ConcatFunc {
DataType::Utf8View => {
let string_array = as_string_view_array(array)?;
- data_size += string_array.len();
+ data_size += string_array
Review Comment:
Thank you, nice suggestion! This is done. I also made this change for
`concat_ws`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]