neilconway commented on code in PR #20317:
URL: https://github.com/apache/datafusion/pull/20317#discussion_r2822865192
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -207,7 +207,7 @@ impl ScalarUDFImpl for ConcatFunc {
DataType::Utf8View => {
let string_array = as_string_view_array(array)?;
- data_size += string_array.len();
+ data_size +=
string_array.total_buffer_bytes_used();
Review Comment:
The code in Arrow casts `*v` to `u32`, which takes the low 32 bits. Summing
all 128 bit values and then taking the min of that value and `usize::MAX` does
not seem to do the right thing, unless I'm misunderstanding completely.
In any case, I'd prefer to not depend on Arrow implementation details, if we
can avoid it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
