Acfboy commented on code in PR #20306: URL: https://github.com/apache/datafusion/pull/20306#discussion_r2806808454
########## datafusion/sqllogictest/test_files/type_coercion.slt: ########## @@ -281,3 +281,30 @@ SELECT true FROM t0 WHERE (REGEXP_MATCH(t0.v1, t0.v1)) NOT ILIKE []; statement ok DROP TABLE t0; + +############################################################################### +## Test that IS NULL / IS NOT NULL / SIMILAR TO / CAST / TRY_CAST validate ## +## their inner expressions. ## +############################################################################### + +# https://github.com/apache/datafusion/issues/20201 + +# IS NULL should reject invalid inner expression Review Comment: Thanks for the review, @alamb and @neilconway. I have removed the redundant unit tests in type_coercion.rs and will rely on the .slt tests for coverage as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
