Dandandan commented on code in PR #19639:
URL: https://github.com/apache/datafusion/pull/19639#discussion_r2807921209
##########
datafusion/common/src/config.rs:
##########
@@ -751,6 +751,16 @@ config_namespace! {
/// parquet reader setting. 0 means no caching.
pub max_predicate_cache_size: Option<usize>, default = None
+ /// (reading) Minimum filter effectiveness threshold for adaptive
filter
+ /// pushdown.
+ /// Only filters that filter out at least this fraction of rows will be
+ /// promoted to row filters during adaptive filter pushdown.
+ /// A value of 1.0 means only filters that filter out all rows will be
+ /// promoted. A value of 0.0 means all filters will be promoted.
+ /// Because there can be a high I/O cost to pushing down ineffective
filters,
+ /// recommended values are in the range [0.8, 0.95], depending on
random I/0 costs.
+ pub filter_effectiveness_threshold: f64, default = 0.8
Review Comment:
Can we check 0.5 as well here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
