tokoko opened a new pull request, #3523: URL: https://github.com/apache/datafusion-comet/pull/3523
Closes #3522. ## What changes are included in this PR? - obtains object storage credentials from FileIO objects through reflection and merges them with hadoop properties that are passed to native scanner. - there is `SupportsStorageCredentials` interface in latest iceberg which should eventually make reflection code less ugly, but we can't use it yet. - updates `RestCatalogAdapter` test utility to enable fake credential vending for testing. - this **won't** handle credential refresh in case temporary credentials expire. that's much harder problem to tackle. ## How are these changes tested? - tested with `RestCatalogAdapter` that injects minio credentials into LoadTable response objects. - a negative test with wrong temporary credentials to make sure that it's the vended credentials that are being used rather than the ones set in hadoop configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
