neilconway opened a new pull request, #20361: URL: https://github.com/apache/datafusion/pull/20361
## Which issue does this PR close? - Closes #20360 ## Rationale for this change concat_ws only handled Utf8 separators (despite its signature claiming otherwise). Attempting to pass a Utf8View or LargeUtf8 separator would result in a panic or internal error. ## What changes are included in this PR? * Add SLT test case for array Utf8View separator * Add unit test for scalar Utf8View separator * Fix behavior: add support for LargeUtf8 and Utf8View separators, both array and scalar * Other minor code cleanups and improvements ## Are these changes tested? Yes. Added new test cases. Note that we can't easily the scalar separator case via SQL, because `simplify_concat_ws` happens to cast constant/scalar separators to Utf8. That behavior is dubious and should be changed, but I'll tackle that in a subsequent PR. ## Are there any user-facing changes? No, aside from a previously failing query now succeeding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
