neilconway commented on code in PR #20361:
URL: https://github.com/apache/datafusion/pull/20361#discussion_r2809204758
##########
datafusion/functions/src/string/concat_ws.rs:
##########
@@ -546,4 +564,41 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn concat_ws_utf8view_scalar_separator() -> Result<()> {
Review Comment:
Thank you! Added.
##########
datafusion/sqllogictest/test_files/expr.slt:
##########
@@ -504,6 +504,19 @@ abc
statement ok
drop table foo
+# concat_ws with a Utf8View column as separator
+statement ok
+create table test_concat_ws_sep (sep varchar, val1 varchar, val2 varchar) as
values (',', 'foo', 'bar'), ('|', 'a', 'b');
+
+query T
+SELECT concat_ws(arrow_cast(sep, 'Utf8View'), val1, val2) FROM
test_concat_ws_sep ORDER BY val1
Review Comment:
Thank you! Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
