Omega359 commented on code in PR #11403:
URL: https://github.com/apache/datafusion/pull/11403#discussion_r1677175082
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -976,6 +872,713 @@ impl SessionState {
}
}
+/// A builder to be used for building [`SessionState`]'s. Defaults will
+/// be used for all values unless explicitly provided.
+pub struct SessionStateBuilder {
+ session_id: Option<String>,
+ analyzer: Option<Analyzer>,
+ expr_planners: Option<Vec<Arc<dyn ExprPlanner>>>,
+ optimizer: Option<Optimizer>,
+ physical_optimizers: Option<PhysicalOptimizer>,
+ query_planner: Option<Arc<dyn QueryPlanner + Send + Sync>>,
+ catalog_list: Option<Arc<dyn CatalogProviderList>>,
+ table_functions: Option<HashMap<String, Arc<TableFunction>>>,
+ scalar_functions: Option<Vec<Arc<ScalarUDF>>>,
+ aggregate_functions: Option<Vec<Arc<AggregateUDF>>>,
+ window_functions: Option<Vec<Arc<WindowUDF>>>,
+ serializer_registry: Option<Arc<dyn SerializerRegistry>>,
+ file_formats: Option<Vec<Arc<dyn FileFormatFactory>>>,
+ config: Option<SessionConfig>,
+ table_options: Option<TableOptions>,
+ execution_props: Option<ExecutionProps>,
+ table_factories: Option<HashMap<String, Arc<dyn TableProviderFactory>>>,
+ runtime_env: Option<Arc<RuntimeEnv>>,
+ function_factory: Option<Arc<dyn FunctionFactory>>,
+ // fields to support convenience functions
+ analyzer_rules: Option<Vec<Arc<dyn AnalyzerRule + Send + Sync>>>,
+ optimizer_rules: Option<Vec<Arc<dyn OptimizerRule + Send + Sync>>>,
+ physical_optimizer_rules: Option<Vec<Arc<dyn PhysicalOptimizerRule + Send
+ Sync>>>,
+}
+
+impl SessionStateBuilder {
+ /// Returns a new [`SessionStateBuilder`] with no options set.
+ pub fn new() -> Self {
+ Self {
+ session_id: None,
+ analyzer: None,
+ expr_planners: None,
+ optimizer: None,
+ physical_optimizers: None,
+ query_planner: None,
+ catalog_list: None,
+ table_functions: None,
+ scalar_functions: None,
+ aggregate_functions: None,
+ window_functions: None,
+ serializer_registry: None,
+ file_formats: None,
+ table_options: None,
+ config: None,
+ execution_props: None,
+ table_factories: None,
+ runtime_env: None,
+ function_factory: None,
+ // fields to support convenience functions
+ analyzer_rules: None,
+ optimizer_rules: None,
+ physical_optimizer_rules: None,
+ }
+ }
+
+ /// Returns a new [SessionStateBuilder] based on an existing [SessionState]
+ /// The session id for the new builder will be unset; all other fields will
+ /// be cloned from what is set in the provided session state
+ pub fn new_from_existing(existing: SessionState) -> Self {
+ let cloned = existing.clone();
Review Comment:
leftover from a previous iteration, I'll remove. thx for the catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
