alamb commented on code in PR #11403:
URL: https://github.com/apache/datafusion/pull/11403#discussion_r1677188296
##########
datafusion-cli/src/catalog.rs:
##########
@@ -178,13 +180,18 @@ impl SchemaProvider for DynamicFileSchemaProvider {
// to any command options so the only choice is to use an
empty collection
match scheme {
"s3" | "oss" | "cos" => {
- state =
state.add_table_options_extension(AwsOptions::default());
+ if let Some(table_options) = builder.table_options() {
Review Comment:
Maybe we can clean it up as a follow on -- it is not critical in my opinion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
