timsaucer commented on code in PR #20414:
URL: https://github.com/apache/datafusion/pull/20414#discussion_r2818270003
##########
.github/workflows/docs.yaml:
##########
@@ -40,17 +40,11 @@ jobs:
ref: asf-site
path: asf-site
- - name: Setup Python
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #
v6.2.0
- with:
- python-version: "3.12"
+ - name: Setup uv
+ uses: astral-sh/setup-uv@f0ec1fc3b38f5e7cd731bb6ce540c5af426746bb #
v6.1.0
Review Comment:
Same as below, do we need to specific a specific sha here?
##########
pyproject.toml:
##########
@@ -0,0 +1,2 @@
+[tool.uv.workspace]
+members = ["benchmarks", "dev", "docs"]
Review Comment:
Is there a reason to use three `pyproject.toml` files instead of just one
here at the root and three dependency groups?
##########
.github/workflows/docs_pr.yaml:
##########
@@ -44,16 +44,10 @@ jobs:
with:
submodules: true
fetch-depth: 1
- - name: Setup Python
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #
v6.2.0
- with:
- python-version: "3.12"
+ - name: Setup uv
+ uses: astral-sh/setup-uv@f0ec1fc3b38f5e7cd731bb6ce540c5af426746bb #
v6.1.0
Review Comment:
Is the specific commit a requirement? I think `astral-sh/setup-uv@v6` is
pretty stable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
