adriangb commented on code in PR #20414:
URL: https://github.com/apache/datafusion/pull/20414#discussion_r2819706516
##########
.github/workflows/docs_pr.yaml:
##########
@@ -44,16 +44,10 @@ jobs:
with:
submodules: true
fetch-depth: 1
- - name: Setup Python
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #
v6.2.0
- with:
- python-version: "3.12"
+ - name: Setup uv
+ uses: astral-sh/setup-uv@f0ec1fc3b38f5e7cd731bb6ce540c5af426746bb #
v6.1.0
Review Comment:
No, but it is generally encouraged to lock to commits in GHA: a commit
provides an immutable reference to "safe" code. A tag is mutable. If a
malicious actor gains control of an action repository they can upload a new v6
and infect everyone. If everyone is pinned to the commit they can't force the
malicious code into everyone's CI unless you opt in by updating the hash. TLDR
because there are no lockfiles for CI and because CI is a critical vector for
supply chain attacks it's best to pin to a hash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
