Jefffrey commented on code in PR #20368:
URL: https://github.com/apache/datafusion/pull/20368#discussion_r2822441821
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -772,6 +784,13 @@ struct Options {
default_value_t = get_available_parallelism()
)]
test_threads: usize,
+
+ #[clap(
+ long,
+ value_name = "WHEN",
Review Comment:
```suggestion
value_name = "MODE",
```
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -813,6 +832,29 @@ impl Options {
eprintln!("WARNING: Ignoring `--show-output` compatibility
option");
}
}
+
+ /// Determine if colour output should be enabled, respecting --color,
NO_COLOR, CARGO_TERM_COLOR, and terminal detection
+ fn is_colored(&self) -> bool {
Review Comment:
I'm not as familiar with clap, but I feel some of this logic can be encoded
using clap macros on `Options`? For example instead of it being a string it
could be an enum (and thus in `help` we wouldn't need to mention the valid
values ourselves?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
