neilconway commented on code in PR #20374:
URL: https://github.com/apache/datafusion/pull/20374#discussion_r2827647275
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -362,24 +373,34 @@ fn array_has_dispatch_for_scalar(
ArrayWrapper::LargeList(arr) => arr.nulls(),
};
- for (i, (start, end)) in haystack.offsets().tuple_windows().enumerate() {
- let length = end - start;
+ let offsets: Vec<usize> = haystack.offsets().collect();
+ let mut matches = eq_bits.set_indices().peekable();
Review Comment:
Interesting idea. Most of the time, the bitmap should be sparse, so I don't
think `set_slices()` would be a win. It would also be a bit trickier to write
the logic to handle contiguous slices of set bits. I'd prefer to defer this for
now if that's okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
