zhangxffff commented on PR #20428: URL: https://github.com/apache/datafusion/pull/20428#issuecomment-3932066774
> > Yes. Add 7 testcase to cover dynamic in path. Also add New criterion benchmarks (bench_dynamic_int32, bench_dynamic_utf8). > > Could you make a PR adding just the benchmarks first? That way we can merge that and then show a clear improvement on this PR Thank you so much for your review! I’ve opened a separate PR (#20444) focused on adding the benchmarks first, and would greatly appreciate it if you could take a look at this code when you have some time. I will follow up with further optimizations separately after #20444 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
