helgikrs commented on code in PR #20447:
URL: https://github.com/apache/datafusion/pull/20447#discussion_r2834849492
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -738,7 +738,7 @@ impl HashJoinExec {
}
fn allow_join_dynamic_filter_pushdown(&self, config: &ConfigOptions) ->
bool {
- if self.join_type != JoinType::Inner
+ if !matches!(self.join_type, JoinType::Inner | JoinType::Left |
JoinType::LeftSemi)
Review Comment:
Actually I think it might be safe to add RightSemi and LeftAnti to this list.
The dynamic filter only removes probe rows that can't match any build row,
and neither RightSemi (which outputs only matched probe rows) nor LeftAnti
(which outputs only unmatched build rows) includes unmatched probe rows in its
output. So I think it would be safe to add those here as well. Right and
RightAnti would not be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
