adriangb commented on PR #20447: URL: https://github.com/apache/datafusion/pull/20447#issuecomment-3977456883
Thank you @helgikrs! @nuno-faria how do you feel about testing? On the one hand we are now using a well tested logic for when it is safe to push down join clause filters. On the other hand I am hesitant to merge this without tests. I personally feel it would be nice to have join fuzz tests that verify that with / without dynamic filters results are the same. But that would be a big change that delays this PR, I don't want to block it. One thing we could do is wait until the 53 release branch is cut (next week or so I think) and merge this after, so we at least have a month to fix any bugs. But if you are confident this is correct then I'm also happy to merge it as is. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
