adriangb commented on code in PR #20455:
URL: https://github.com/apache/datafusion/pull/20455#discussion_r2836945745
##########
datafusion/physical-plan/src/joins/sort_merge_join/exec.rs:
##########
@@ -594,4 +600,56 @@ impl ExecutionPlan for SortMergeJoinExec {
self.null_equality,
)?)))
}
+
+ fn gather_filters_for_pushdown(
+ &self,
+ _phase: FilterPushdownPhase,
+ parent_filters: Vec<Arc<dyn PhysicalExpr>>,
+ _config: &ConfigOptions,
+ ) -> Result<FilterDescription> {
+ // Only support Inner joins for now — other join types have complex
+ // column routing semantics (e.g. nullable sides, semi/anti output
+ // restrictions) that require careful handling.
Review Comment:
We've now added support for other joins in HashJoinExec - could we do the
same here from the get go? May require refactoring out some shared code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
