Dandandan commented on issue #20324:
URL: https://github.com/apache/datafusion/issues/20324#issuecomment-3943147249
I reran the benchmarks, as they were a bit too good to be true (turns out
they were for pushdown). But still getting good results:
```
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┓
┃ Query ┃ main ┃
parquet-morsel-driven-execution-237164415184908839 ┃ Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 888.03 ms │ 1005.51
ms │ 1.13x slower │
│ QQuery 1 │ 298.74 ms │ 253.19
ms │ +1.18x faster │
│ QQuery 2 │ 669.67 ms │ 577.42
ms │ +1.16x faster │
│ QQuery 3 │ 500.88 ms │ 415.63
ms │ +1.21x faster │
│ QQuery 4 │ 750.81 ms │ 815.64
ms │ 1.09x slower │
│ QQuery 5 │ 10765.06 ms │ 10392.77
ms │ no change │
│ QQuery 6 │ 1468.42 ms │ 2.07
ms │ +710.78x faster │
│ QQuery 7 │ 1146.72 ms │ 1072.55
ms │ +1.07x faster │
└──────────┴─────────────┴────────────────────────────────────────────────────┴─────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃
┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (main) │
16488.33ms │
│ Total Time (parquet-morsel-driven-execution-237164415184908839) │
14534.77ms │
│ Average Time (main) │
2061.04ms │
│ Average Time (parquet-morsel-driven-execution-237164415184908839) │
1816.85ms │
│ Queries Faster │
5 │
│ Queries Slower │
2 │
│ Queries with No Change │
1 │
│ Queries with Failure │
0 │
└───────────────────────────────────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ main ┃
parquet-morsel-driven-execution-237164415184908839 ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 1.04 ms │ 1.04
ms │ no change │
│ QQuery 1 │ 14.08 ms │ 16.24
ms │ 1.15x slower │
│ QQuery 2 │ 48.33 ms │ 46.40
ms │ no change │
│ QQuery 3 │ 47.06 ms │ 45.26
ms │ no change │
│ QQuery 4 │ 366.76 ms │ 369.05
ms │ no change │
│ QQuery 5 │ 535.43 ms │ 450.32
ms │ +1.19x faster │
│ QQuery 6 │ 2.96 ms │ 4.96
ms │ 1.68x slower │
│ QQuery 7 │ 15.86 ms │ 17.48
ms │ 1.10x slower │
│ QQuery 8 │ 488.23 ms │ 482.34
ms │ no change │
│ QQuery 9 │ 692.94 ms │ 631.48
ms │ +1.10x faster │
│ QQuery 10 │ 115.64 ms │ 109.67
ms │ +1.05x faster │
│ QQuery 11 │ 133.16 ms │ 123.68
ms │ +1.08x faster │
│ QQuery 12 │ 508.25 ms │ 430.19
ms │ +1.18x faster │
│ QQuery 13 │ 680.40 ms │ 615.79
ms │ +1.10x faster │
│ QQuery 14 │ 481.06 ms │ 430.01
ms │ +1.12x faster │
│ QQuery 15 │ 432.32 ms │ 436.09
ms │ no change │
│ QQuery 16 │ 990.45 ms │ 1005.22
ms │ no change │
│ QQuery 17 │ 962.77 ms │ 978.92
ms │ no change │
│ QQuery 18 │ 2050.47 ms │ 2095.02
ms │ no change │
│ QQuery 19 │ 40.32 ms │ 37.51
ms │ +1.08x faster │
│ QQuery 20 │ 933.54 ms │ 726.31
ms │ +1.29x faster │
│ QQuery 21 │ 1027.66 ms │ 858.70
ms │ +1.20x faster │
│ QQuery 22 │ 1530.58 ms │ 1478.12
ms │ no change │
│ QQuery 23 │ 4663.56 ms │ 4815.10
ms │ no change │
│ QQuery 24 │ 93.25 ms │ 52.85
ms │ +1.76x faster │
│ QQuery 25 │ 203.85 ms │ 165.61
ms │ +1.23x faster │
│ QQuery 26 │ 94.02 ms │ 54.23
ms │ +1.73x faster │
│ QQuery 27 │ 1126.73 ms │ 964.02
ms │ +1.17x faster │
│ QQuery 28 │ 10180.43 ms │ 9036.37
ms │ +1.13x faster │
│ QQuery 29 │ 364.42 ms │ 320.42
ms │ +1.14x faster │
│ QQuery 30 │ 474.22 ms │ 425.94
ms │ +1.11x faster │
│ QQuery 31 │ 458.37 ms │ 414.97
ms │ +1.10x faster │
│ QQuery 32 │ 2584.13 ms │ 2360.70
ms │ +1.09x faster │
│ QQuery 33 │ 2233.45 ms │ 2202.39
ms │ no change │
│ QQuery 34 │ 2229.80 ms │ 2521.80
ms │ 1.13x slower │
│ QQuery 35 │ 706.55 ms │ 696.50
ms │ no change │
│ QQuery 36 │ 106.00 ms │ 59.85
ms │ +1.77x faster │
│ QQuery 37 │ 43.51 ms │ 32.26
ms │ +1.35x faster │
│ QQuery 38 │ 74.87 ms │ 38.75
ms │ +1.93x faster │
│ QQuery 39 │ 199.26 ms │ 119.58
ms │ +1.67x faster │
│ QQuery 40 │ 18.67 ms │ 11.94
ms │ +1.56x faster │
│ QQuery 41 │ 16.78 ms │ 11.80
ms │ +1.42x faster │
│ QQuery 42 │ 13.52 ms │ 9.78
ms │ +1.38x faster │
└───────────┴─────────────┴────────────────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃
┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (main) │
37984.70ms │
│ Total Time (parquet-morsel-driven-execution-237164415184908839) │
35704.65ms │
│ Average Time (main) │
883.37ms │
│ Average Time (parquet-morsel-driven-execution-237164415184908839) │
830.34ms │
│ Queries Faster │
26 │
│ Queries Slower │
4 │
│ Queries with No Change │
13 │
│ Queries with Failure │
0 │
└───────────────────────────────────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_pushdown.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ main ┃
parquet-morsel-driven-execution-237164415184908839 ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 0.94 ms │ 0.89
ms │ no change │
│ QQuery 1 │ 15.46 ms │ 17.03
ms │ 1.10x slower │
│ QQuery 2 │ 47.74 ms │ 47.21
ms │ no change │
│ QQuery 3 │ 47.91 ms │ 46.42
ms │ no change │
│ QQuery 4 │ 377.94 ms │ 380.81
ms │ no change │
│ QQuery 5 │ 531.75 ms │ 463.25
ms │ +1.15x faster │
│ QQuery 6 │ 5.65 ms │ 5.99
ms │ 1.06x slower │
│ QQuery 7 │ 21.40 ms │ 21.74
ms │ no change │
│ QQuery 8 │ 485.04 ms │ 489.23
ms │ no change │
│ QQuery 9 │ 685.29 ms │ 628.46
ms │ +1.09x faster │
│ QQuery 10 │ 153.55 ms │ 143.76
ms │ +1.07x faster │
│ QQuery 11 │ 167.04 ms │ 158.46
ms │ +1.05x faster │
│ QQuery 12 │ 540.31 ms │ 463.87
ms │ +1.16x faster │
│ QQuery 13 │ 689.88 ms │ 668.03
ms │ no change │
│ QQuery 14 │ 525.73 ms │ 458.53
ms │ +1.15x faster │
│ QQuery 15 │ 451.15 ms │ 429.07
ms │ no change │
│ QQuery 16 │ 1024.55 ms │ 972.48
ms │ +1.05x faster │
│ QQuery 17 │ 992.24 ms │ 950.12
ms │ no change │
│ QQuery 18 │ 1998.18 ms │ 2153.69
ms │ 1.08x slower │
│ QQuery 19 │ 44.15 ms │ 40.87
ms │ +1.08x faster │
│ QQuery 20 │ 944.79 ms │ 717.18
ms │ +1.32x faster │
│ QQuery 21 │ 977.02 ms │ 843.59
ms │ +1.16x faster │
│ QQuery 22 │ 1514.11 ms │ 1449.66
ms │ no change │
│ QQuery 23 │ 381.34 ms │ 170.80
ms │ +2.23x faster │
│ QQuery 24 │ 113.30 ms │ 51.19
ms │ +2.21x faster │
│ QQuery 25 │ 262.47 ms │ 223.74
ms │ +1.17x faster │
│ QQuery 26 │ 161.43 ms │ 74.77
ms │ +2.16x faster │
│ QQuery 27 │ 1236.38 ms │ 1045.83
ms │ +1.18x faster │
│ QQuery 28 │ 10319.06 ms │ 9246.37
ms │ +1.12x faster │
│ QQuery 29 │ 358.66 ms │ 314.35
ms │ +1.14x faster │
│ QQuery 30 │ 473.48 ms │ 427.07
ms │ +1.11x faster │
│ QQuery 31 │ 455.18 ms │ 424.80
ms │ +1.07x faster │
│ QQuery 32 │ 2087.10 ms │ 2558.84
ms │ 1.23x slower │
│ QQuery 33 │ 2146.63 ms │ 2317.84
ms │ 1.08x slower │
│ QQuery 34 │ 2292.89 ms │ 2766.27
ms │ 1.21x slower │
│ QQuery 35 │ 718.07 ms │ 706.21
ms │ no change │
│ QQuery 36 │ 91.43 ms │ 61.60
ms │ +1.48x faster │
│ QQuery 37 │ 51.60 ms │ 37.37
ms │ +1.38x faster │
│ QQuery 38 │ 52.58 ms │ 35.61
ms │ +1.48x faster │
│ QQuery 39 │ 160.05 ms │ 104.88
ms │ +1.53x faster │
│ QQuery 40 │ 29.39 ms │ 19.89
ms │ +1.48x faster │
│ QQuery 41 │ 26.49 ms │ 17.91
ms │ +1.48x faster │
│ QQuery 42 │ 18.22 ms │ 12.23
ms │ +1.49x faster │
└───────────┴─────────────┴────────────────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃
┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (main) │
33677.56ms │
│ Total Time (parquet-morsel-driven-execution-237164415184908839) │
32167.88ms │
│ Average Time (main) │
783.20ms │
│ Average Time (parquet-morsel-driven-execution-237164415184908839) │
748.09ms │
│ Queries Faster │
26 │
│ Queries Slower │
6 │
│ Queries with No Change │
11 │
│ Queries with Failure │
0 │
└───────────────────────────────────────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query ┃ main ┃ parquet-morsel-driven-execution-237164415184908839
┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 1 │ 77.57 ms │ 77.57 ms
│ no change │
│ QQuery 2 │ 41.27 ms │ 41.13 ms
│ no change │
│ QQuery 3 │ 49.50 ms │ 49.79 ms
│ no change │
│ QQuery 4 │ 36.79 ms │ 36.42 ms
│ no change │
│ QQuery 5 │ 64.85 ms │ 66.16 ms
│ no change │
│ QQuery 6 │ 24.49 ms │ 24.84 ms
│ no change │
│ QQuery 7 │ 74.28 ms │ 74.31 ms
│ no change │
│ QQuery 8 │ 69.07 ms │ 70.09 ms
│ no change │
│ QQuery 9 │ 89.52 ms │ 89.43 ms
│ no change │
│ QQuery 10 │ 84.54 ms │ 84.90 ms
│ no change │
│ QQuery 11 │ 26.99 ms │ 26.79 ms
│ no change │
│ QQuery 12 │ 51.52 ms │ 52.86 ms
│ no change │
│ QQuery 13 │ 119.33 ms │ 120.11 ms
│ no change │
│ QQuery 14 │ 35.97 ms │ 36.81 ms
│ no change │
│ QQuery 15 │ 40.64 ms │ 41.74 ms
│ no change │
│ QQuery 16 │ 28.08 ms │ 28.32 ms
│ no change │
│ QQuery 17 │ 97.26 ms │ 98.76 ms
│ no change │
│ QQuery 18 │ 117.66 ms │ 119.44 ms
│ no change │
│ QQuery 19 │ 55.89 ms │ 56.63 ms
│ no change │
│ QQuery 20 │ 52.98 ms │ 52.69 ms
│ no change │
│ QQuery 21 │ 89.56 ms │ 91.00 ms
│ no change │
│ QQuery 22 │ 18.42 ms │ 18.60 ms
│ no change │
└───────────┴───────────┴────────────────────────────────────────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃
┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (main) │
1346.17ms │
│ Total Time (parquet-morsel-driven-execution-237164415184908839) │
1358.38ms │
│ Average Time (main) │
61.19ms │
│ Average Time (parquet-morsel-driven-execution-237164415184908839) │
61.74ms │
│ Queries Faster │
0 │
│ Queries Slower │
0 │
│ Queries with No Change │
22 │
│ Queries with Failure │
0 │
└───────────────────────────────────────────────────────────────────┴───────────┘
--------------------
Benchmark tpch_sf10.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query ┃ main ┃
parquet-morsel-driven-execution-237164415184908839 ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1 │ 530.11 ms │ 547.41
ms │ no change │
│ QQuery 2 │ 120.45 ms │ 121.96
ms │ no change │
│ QQuery 3 │ 359.06 ms │ 378.49
ms │ 1.05x slower │
│ QQuery 4 │ 186.42 ms │ 191.28
ms │ no change │
│ QQuery 5 │ 529.28 ms │ 546.25
ms │ no change │
│ QQuery 6 │ 176.91 ms │ 181.17
ms │ no change │
│ QQuery 7 │ 715.92 ms │ 738.24
ms │ no change │
│ QQuery 8 │ 551.52 ms │ 571.76
ms │ no change │
│ QQuery 9 │ 840.61 ms │ 854.68
ms │ no change │
│ QQuery 10 │ 429.98 ms │ 435.94
ms │ no change │
│ QQuery 11 │ 96.37 ms │ 97.49
ms │ no change │
│ QQuery 12 │ 268.06 ms │ 280.03
ms │ no change │
│ QQuery 13 │ 352.76 ms │ 396.81
ms │ 1.12x slower │
│ QQuery 14 │ 230.51 ms │ 240.39
ms │ no change │
│ QQuery 15 │ 340.44 ms │ 342.36
ms │ no change │
│ QQuery 16 │ 79.96 ms │ 81.67
ms │ no change │
│ QQuery 17 │ 952.83 ms │ 989.26
ms │ no change │
│ QQuery 18 │ 1097.49 ms │ 1110.96
ms │ no change │
│ QQuery 19 │ 368.82 ms │ 367.51
ms │ no change │
│ QQuery 20 │ 335.05 ms │ 334.54
ms │ no change │
│ QQuery 21 │ 973.47 ms │ 983.11
ms │ no change │
│ QQuery 22 │ 93.95 ms │ 100.63
ms │ 1.07x slower │
└───────────┴────────────┴────────────────────────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃
┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (main) │
9629.97ms │
│ Total Time (parquet-morsel-driven-execution-237164415184908839) │
9891.95ms │
│ Average Time (main) │
437.73ms │
│ Average Time (parquet-morsel-driven-execution-237164415184908839) │
449.63ms │
│ Queries Faster │
0 │
│ Queries Slower │
3 │
│ Queries with No Change │
19 │
│ Queries with Failure │
0 │
└───────────────────────────────────────────────────────────────────┴───────────┘
```
So still having >2x speedups, but the difference is not as big (probably ran
against a slow / outdated run) for a ~6% improvement overall.
Have to look at whether `QQuery 6` for clickbench extended is even right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
