alamb commented on code in PR #20421:
URL: https://github.com/apache/datafusion/pull/20421#discussion_r2849542704
##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -129,6 +129,14 @@ CREATE TABLE group_median_table_nullable (
# Error tests
#######
+statement error ORDER BY must be specified using WITHIN GROUP
+select quantile_cont(col0, 0.75 order by col0)
+from values (1, 3), (2, 2), (3, 1) t(col0, col1);
+
+statement error ORDER BY must be specified using WITHIN GROUP
Review Comment:
I double checked that these queries fail on main too:
```sql
> select quantile_cont(0.75 order by col0)
from values (1, 3), (2, 2), (3, 1) t(col0, col1);
Error during planning: Function 'percentile_cont' expects 2 arguments but
received 1 No function matches the given name and argument types
'percentile_cont(Float64)'. You might need to add explicit type casts.
Candidate functions:
percentile_cont(expr: Coercion(TypeSignatureClass::Float,
implicit_coercion=ImplicitCoercion([Numeric], default_type=Float64),
percentile: Coercion(TypeSignatureClass::Native(LogicalType(Native(Float64),
Float64)), implicit_coercion=ImplicitCoercion([Numeric], default_type=Float64))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
