Jefffrey commented on code in PR #20421: URL: https://github.com/apache/datafusion/pull/20421#discussion_r2850652099
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -129,6 +129,14 @@ CREATE TABLE group_median_table_nullable ( # Error tests ####### +statement error ORDER BY must be specified using WITHIN GROUP +select quantile_cont(col0, 0.75 order by col0) +from values (1, 3), (2, 2), (3, 1) t(col0, col1); + +statement error ORDER BY must be specified using WITHIN GROUP Review Comment: The query above currently succeeds on main ```sql select quantile_cont(col0, 0.75 order by col0) from values (1, 3), (2, 2), (3, 1) t(col0, col1); ``` I was thinking this could be a breaking change, but I wonder how often these (ordered set aggregates) are currently used especially with an `order by` in the argument list like this; if we want to be fully explicit we can add an entry to the upgrade guide -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
