milenkovicm commented on PR #20249: URL: https://github.com/apache/datafusion/pull/20249#issuecomment-3955094748
Half part of code using`&SessionState` and the other half using `&dyn Session` is a bit inconsistent; not sure how to fix it without impacting everything. If you take a look at `DefaultQueryPlanner`, there has to be downcast at some point, either in `create_physical_plan` as it is currently implemented or somewhere deep in the code (can't really remember at which point). To be honest, I did not come back to this PR as I'm a bit scared to get into that rabbit hole :) If you're into FFI work, and you wish taking over this functionality please feel free to do so, otherwise i'll try to get back to it over the weekend -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
