timsaucer commented on PR #20249: URL: https://github.com/apache/datafusion/pull/20249#issuecomment-3954838147
I did a little playing around with this to see how it would fit in with ballista + datafusion-python. I'm becoming convinced that we want to move `PhysicalPlanner` and `ExtensionPlanner` also out of `core` and into `datafusion-session` and move from taking `&SessionState` to `&dyn Session`. This would mean also moving `PhysicalOptimizerRule` out to `datafusion_physical_plan` in order to break a circular dependency. The good news is that my work on https://github.com/apache/datafusion/issues/20450 would already support adding the physical optimizers to `FFI_Session`. I ran into these issues because I found that we are relying on downcasting to `SessionState` and that won't work when we're passing around a `FFI_Session`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
