andygrove opened a new pull request, #3614: URL: https://github.com/apache/datafusion-comet/pull/3614
## Summary - Replace protobuf-based metric updates with a flat `long[]` array approach for faster native-to-JVM metric transfer - Pre-allocate parallel arrays (metric names, SQLMetrics, node offsets) at plan creation via DFS walk of `CometMetricNode` tree - Native side fills a `Vec<i64>` and copies to JVM via single `SetLongArrayRegion` bulk JNI call instead of protobuf encode/decode - JVM reads linearly from the array — no protobuf, no tree walking, no map lookups, no string allocations per update cycle - Remove `metric.proto` and all protobuf metric infrastructure ## Test plan - [x] `cargo clippy --all-targets --workspace -- -D warnings` passes - [x] Full `make` build succeeds (native + JVM) - [ ] `make test-jvm` — metrics are validated by Spark UI tests - [ ] `./mvnw test -Dsuites="org.apache.comet.exec.CometExecSuite"` — core execution tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
