killzoner commented on PR #1478: URL: https://github.com/apache/datafusion-ballista/pull/1478#issuecomment-3983528491
> > It's pretty clean! One thing I always wonder when seeing such refactoring, since stream can always do 1 one off response, should we simplify the gRPC endpoints to have only 1 `ExecuteQuery` that does streaming with 1 or multiple responses? It comes at its own cost though because this involves refactoring the existing, and a breaking change > > thanks @killzoner having two implementation is not ideal, so once we test out this new method we should think about the old one. > > I tend to keep it, as it is, to support cases which start the job and then come back after some time (afew minutes or so) to check if the job has finished, but I would definitely remove it from the client interface, as the new interface should cover all cases there. What do you think ? Clear if the goal is to make this new implementation first class and we would like to keep 1 ideally in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
