milenkovicm commented on code in PR #1478:
URL:
https://github.com/apache/datafusion-ballista/pull/1478#discussion_r2872237258
##########
ballista/scheduler/src/cluster/memory.rs:
##########
@@ -380,12 +380,34 @@ impl InMemoryJobState {
}
}
+#[derive(Clone)]
+struct ExtendedJobStatus {
+ status: JobStatus,
+ subscriber: Option<JobStatusSubscriber>,
+}
+
+impl ExtendedJobStatus {
+ async fn update_subscribers(&self, status: JobStatus) {
+ if let Some(subscriber) = &self.subscriber {
+ let _ = subscriber.send(status).await;
Review Comment:
you're right, but there is hand full of states job can go through, the
underlying channel is setup with buffer of 16 ( i would even increase it)
rather than complicating code with new task. wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
