0lai0 commented on code in PR #3618:
URL: https://github.com/apache/datafusion-comet/pull/3618#discussion_r2876515218
##########
spark/src/main/spark-3.4/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -43,6 +45,9 @@ trait CometExprShim extends CommonStringExprs {
// Right child is the encoding expression.
stringDecode(expr, s.charset, s.bin, inputs, binding)
+ case _ if expr.getClass.getSimpleName == "SecondOfTime" =>
Review Comment:
Thanks for review. Sorry to miss 's', I will fix it in next commit.
##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -408,4 +408,50 @@ trait CommonStringExprs {
None
}
}
+
+ def secondOfTimeToProto(
Review Comment:
Thanks for the feedback. I'll make changes based on your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
