martin-g commented on code in PR #3618:
URL: https://github.com/apache/datafusion-comet/pull/3618#discussion_r2888185324
##########
spark/src/main/spark-3.4/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -43,6 +43,9 @@ trait CometExprShim extends CommonStringExprs {
// Right child is the encoding expression.
stringDecode(expr, s.charset, s.bin, inputs, binding)
+ case e if e.getClass.getName ==
"org.apache.spark.sql.catalyst.expressions.SecondsOfTime" =>
Review Comment:
Since `import org.apache.spark.sql.catalyst.expressions._` is already done
you could just do:
```suggestion
case _: SecondsOfTime =>
```
##########
spark/src/main/spark-4.0/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -113,6 +113,9 @@ trait CometExprShim extends CommonStringExprs {
// val optExpr = scalarFunctionExprToProto("width_bucket", childExprs:
_*)
// optExprWithInfo(optExpr, wb, wb.children: _*)
+ case e if e.getClass.getName ==
"org.apache.spark.sql.catalyst.expressions.SecondsOfTime" =>
Review Comment:
```suggestion
case _: SecondsOfTime =>
```
##########
spark/src/main/spark-3.5/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -91,6 +91,9 @@ trait CometExprShim extends CommonStringExprs {
// val optExpr = scalarFunctionExprToProto("width_bucket", childExprs:
_*)
// optExprWithInfo(optExpr, wb, wb.children: _*)
+ case e if e.getClass.getName ==
"org.apache.spark.sql.catalyst.expressions.SecondsOfTime" =>
Review Comment:
```suggestion
case _: SecondsOfTime =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
