Jefffrey commented on PR #20421: URL: https://github.com/apache/datafusion/pull/20421#issuecomment-3990246536
> Unless we have some sort of more compelling story (like "it was getting the wrong answer and now you get an error which is better") it is hard to justify such changes I believe this might be the case here? As far as I'm aware, the `order by` syntax here essentially does nothing, so if there is a query like: ```sql select quantile_cont(col0, 0.75 order by col0 desc) from values (1, 3), (2, 2), (3, 1) t(col0, col1); ``` Then it is would actually be computed as ascending (the default since `within group` isn't specified). Fixing to support `order by` is also a good move, though that might be more subtle as any such queries would now return a different result 🤔 (i.e. harder to make users aware of this new behaviour) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
