alamb commented on code in PR #20610:
URL: https://github.com/apache/datafusion/pull/20610#discussion_r2877698578
##########
datafusion/optimizer/Cargo.toml:
##########
@@ -49,6 +49,7 @@ chrono = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
datafusion-expr = { workspace = true }
datafusion-expr-common = { workspace = true }
+datafusion-functions = { workspace = true }
Review Comment:
Please let's not add this dependency -- doing so makes it harder for others
to extend the datafusion optimizer and functions as the optimizer now assumes
the built in functions
##########
datafusion/optimizer/src/simplify_expressions/regex.rs:
##########
@@ -15,10 +15,14 @@
// specific language governing permissions and limitations
// under the License.
-use datafusion_common::{DataFusionError, Result, ScalarValue};
+use datafusion_common::tree_node::Transformed;
+use datafusion_common::{DataFusionError, Result};
use datafusion_expr::{BinaryExpr, Expr, Like, Operator, lit};
+use datafusion_functions::expr_fn::contains;
Review Comment:
I thought that contains is the same as the `LIKE '%foo%' implementation --
they both use the same underlying optimized arrow kernel don't they?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
